Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s2e-core pre v8 #91

Closed
wants to merge 13 commits into from
Closed

Conversation

200km
Copy link
Member

@200km 200km commented Apr 27, 2024

Issue

NA

詳細

s2e-coreの最新の更新を取り込みたいという要求があったので、s2e-core v8 major update前だが、pre v8としてs2e-aobcに取り込んで更新作業を始める。

検証結果

CI結果参照

補足

NA

@200km 200km added 🚀 priority::high priority high 🐳 major update Major update labels Apr 27, 2024
@200km 200km added this to the Major update v6.0.0 milestone Apr 27, 2024
@200km 200km self-assigned this Apr 27, 2024
@200km 200km requested review from sksat and a team as code owners April 27, 2024 14:38
@200km 200km requested review from seki-hiro, suzuki-toshihir0, t-hosonuma and conjikidow and removed request for a team April 27, 2024 14:38
@200km 200km changed the title [WIP] Update s2e-core pre v8 Update s2e-core pre v8 Apr 27, 2024
Copy link
Member

@seki-hiro seki-hiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@200km こちらも、simulation実行時にerrorが出ていたので、local_environment.iniを修正してpushしました。また、HILS ON時にpower_controllser.cppでerrorが出ていたので、こちらも合わせて修正しています。SILS/HILSともにsimulationが回るのでapproveします。

@200km
Copy link
Member Author

200km commented May 1, 2024

実行時のエラー修正ありがとうございます。

こちら、マージはしないで良いですか?

@seki-hiro
Copy link
Member

どちらでも大丈夫です。ただ、preという名前がついてますし、マージできるならしてしまっていいかと思うのですが、いかがでしょうか?

@sksat
Copy link
Collaborator

sksat commented May 2, 2024

s2e-core v8 のリリース前に v8 作業中のモノを使いたい、ということであれば、使いたい時点の s2e-core の commit で Pre Release を打っておくのがよいと思います(Git tag, GitHub Releases として)

@200km
Copy link
Member Author

200km commented Dec 11, 2024

こちらで本格アップデート始めたのでこれはCLOSE

#102

@200km 200km closed this Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants